Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip variable for remove test resources to support debugging #3341

Merged
1 commit merged into from
May 13, 2022

Conversation

benbp
Copy link
Member

@benbp benbp commented May 12, 2022

In case people want to leave their resources around for debugging after test failures.

The naming format was chosen to be consistent with our other user-facing Skip variables used in the release pipelines (e.g. here).

@benbp benbp requested review from weshaggard and heaths as code owners May 12, 2022 22:43
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label May 12, 2022
@benbp benbp self-assigned this May 12, 2022
@benbp benbp requested a review from mikeharder May 12, 2022 22:43
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but how are they expected to set this? I assume through a manual pipeline run and then set the variable? Should we document that somewhere?

@benbp
Copy link
Member Author

benbp commented May 13, 2022

Looks fine, but how are they expected to set this? I assume through a manual pipeline run and then set the variable? Should we document that somewhere?

Yes, exactly. I was going to update our wiki documentation after merge since that's where I think most of the docs around the live test pipeline lives.

@ghost
Copy link

ghost commented May 13, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit ed82f39 into Azure:main May 13, 2022
@benbp benbp deleted the benbp/remove-test-resources-skip branch May 13, 2022 21:14
@benbp
Copy link
Member Author

benbp commented May 13, 2022

@heaths docs added here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants