-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APIView] Disable build step Create API Review
for private repos
#3433
Conversation
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will work for now. However we might need another solution later if we find that the "-pr" naming convention isn't a strong enough condition.
@weshaggard Agree. I also looked into all steps to see which ones had a similar behavior and so far only 2 (including this one) have it, so decided it was ok for now. If we start having more, then maintaining the behavior on individual steps might not be ideal. |
The following pipelines have been queued for testing: |
@maririos this will be your first eng/common PR. There is a link with instructions on how to process it but let me know if you need any help. |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Fixes #3427