Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIView] Disable build step Create API Review for private repos #3433

Merged
2 commits merged into from
Jun 13, 2022

Conversation

maririos
Copy link
Member

@maririos maririos commented Jun 13, 2022

Fixes #3427

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@maririos maririos marked this pull request as ready for review June 13, 2022 16:59
@praveenkuttappan praveenkuttappan added Central-EngSys This issue is owned by the Engineering System team. APIView labels Jun 13, 2022
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work for now. However we might need another solution later if we find that the "-pr" naming convention isn't a strong enough condition.

@maririos
Copy link
Member Author

@weshaggard Agree. I also looked into all steps to see which ones had a similar behavior and so far only 2 (including this one) have it, so decided it was ok for now. If we start having more, then maintaining the behavior on individual steps might not be ideal.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

@maririos this will be your first eng/common PR. There is a link with instructions on how to process it but let me know if you need any help.

@ghost
Copy link

ghost commented Jun 13, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 094120d into Azure:main Jun 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Disable build step Create API Review in private repositories
4 participants