-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare-Release.ps1: Make dateTime.ToString("MM/dd/yyyy") to work on exotic setups #7615
Conversation
…exotic set-ups On my machine, I experimented with the registry, and the worst part is that I don't remember/know how to reset it back. The work items that script produces, do have datetimes for the upcoming releases in the `MM-dd-yyyy` format, and then I have to correct them by hand. `dateTime.ToString("MM/dd/yyyy")` does produce the date in the format of `MM-dd-yyyy` on my machine. This also happens if I write a corresponding .NET app. The fix that I am proposing makes it work on my specific setup and hopefully breaks no one else. I understand if you are hesitant to take it. Let me know, I'll see how I can restore my setting. But on the other hand, I don't think it makes anything worse, it only makes things more robust, so maybe take it?
The following pipelines have been queued for testing: |
Co-authored-by: Wes Haggard <[email protected]>
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7615 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Anton Kolesnyk <[email protected]> Co-authored-by: Wes Haggard <[email protected]>
On my machine, I experimented with the registry, and the worst part is that I don't remember/know how to reset it back.
The work items that script produces, do have datetimes for the upcoming releases in the
MM-dd-yyyy
format, and then I have to correct them by hand.dateTime.ToString("MM/dd/yyyy")
does produce the date in the format ofMM-dd-yyyy
on my machine. This also happens if I write a corresponding .NET app.The fix that I am proposing makes it work on my specific setup and hopefully breaks no one else. I understand if you are hesitant to take it. Let me know, I'll see how I can restore my setting.
But on the other hand, I don't think it makes anything worse, it only makes things more robust, so maybe take it?