Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use subset of Go module identity for package name #7868

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

jhendrixMSFT
Copy link
Member

This will prevent collisions as the subset is guaranteed to be unique. Updated dependencies.

@jhendrixMSFT jhendrixMSFT requested a review from chlowell March 13, 2024 15:44
@jhendrixMSFT jhendrixMSFT requested review from a team and chidozieononiwu as code owners March 13, 2024 15:44
@jhendrixMSFT
Copy link
Member Author

The build for APIViewWeb is broken, can somebody please take a look?

@maririos
Copy link
Member

@chidozieononiwu could please take a look?

@chidozieononiwu
Copy link
Member

This has been resolved. Could you do a rebase with main.

This will prevent collisions as the subset is guaranteed to be unique.
Updated dependencies.
Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package name must include sdk/ as prefix to match the package name expected in all other tooling for Go.

@praveenkuttappan praveenkuttappan merged commit de61b0c into Azure:main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants