Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eng/common updates for 1es migration #7892

Merged
merged 2 commits into from
Mar 15, 2024
Merged

eng/common updates for 1es migration #7892

merged 2 commits into from
Mar 15, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Mar 15, 2024

  • Move git check for changes to script
  • Minor fixes for 1es migration, proxy log name and os filtering

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Mar 15, 2024
@benbp benbp self-assigned this Mar 15, 2024
@benbp benbp requested a review from scbedd March 15, 2024 21:03
scbedd
scbedd approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp mentioned this pull request Mar 15, 2024
Closed
This was referenced Mar 15, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
benbp added a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 15, 2024
@azure-sdk @benbp
Sync eng/common directory with azure-sdk-tools for PR 7892 (#28944)
0108b2b 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7892 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
@benbp benbp enabled auto-merge (squash) March 15, 2024 21:24
@benbp benbp merged commit ad5a9ec into Azure:main Mar 15, 2024
20 checks passed
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@scbedd scbedd scbedd approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benbp @azure-sdk @weshaggard @scbedd