Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spelling and click display errors in sidebar #7939

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Fixed spelling and click display errors in sidebar #7939

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57fd4f7
Fixed spelling and hover errors
WhitShake Mar 21, 2024
0ff2561
Removed changes and corrected spelling errors
WhitShake Mar 25, 2024
cb3149a
Final spelling corrections
WhitShake Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/dotnet/APIView/APIView/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
"TypeList": {
"commandName": "Project",
"commandLineArgs": "..\\..\\..\\TestLibrary\\Debug\\netcoreapp2.1\\TestLibrary.dll"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you undo this changes?

"WSL": {
"commandName": "WSL2",
"distributionName": ""
}
}
}
6 changes: 3 additions & 3 deletions src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Review.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@
<div id="left-offcanvas-menu" class="left-offcanvas@(leftOffCanvasClass)">
<div class="left-offcanvas-menu-content" id="left-offcanvas-menu-content">
<div class="btn-group-vertical" role="group" aria-label="Vertical button group">
<a type="button" class="btn btn-lg btn-link mb-2" data-bs-toggle="tooltip" data-bs-placement="right" title="API" active-if="@TempData["page"].Equals("api")"><i class="bi bi-braces"></i></a>
<a type="button" class="btn btn-lg btn-link mb-2" data-bs-toggle="offcanvas" data-bs-target="#apiRevisions-context" aria-controls="apiRevisions-context"><i class="bi bi-clock-history" data-bs-toggle="tooltip" data-bs-placement="right" title="Revisons"></i></a>
<a type="button" class="btn btn-lg btn-link mb-2" asp-page="Conversation" asp-route-id="@Model.ReviewContent.Review.Id"><i class="bi bi-chat-left-dots" data-bs-toggle="tooltip" data-bs-placement="right" title="Conversiations"></i>
<a type="button" class="btn btn-lg btn-link mb-2" data-bs-toggle="tooltip" data-bs-placement="right" title="Conversations" active-if="@TempData["page"].Equals("api")"><i class="bi bi-braces"></i></a>
Copy link
Member

@chidozieononiwu chidozieononiwu Mar 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should remain as API

You need to change them in other pages.

Revision spelling at

azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Conversation.cshtml

Line 25 in 1990a3f

<a type="button" class="btn btn-lg btn-link mb-2" asp-page="Revisions" asp-route-id="@Model.Review.Id"><i class="bi bi-clock-history" data-bs-toggle="tooltip" data-bs-placement="right" title="Revisons"></i></a>

API -> Conversation at

azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Conversation.cshtml

Line 26 in 1990a3f

<a type="button" class="btn btn-lg btn-link mb-2" data-bs-toggle="tooltip" data-bs-placement="right" title="API" active-if="@TempData["page"].Equals("conversation")"><i class="bi bi-chat-left-dots"></i></a>

Revision spelling at

azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Revisions.cshtml

Line 35 in 1990a3f

<a type="button" class="btn btn-lg btn-link mb-2" active-if="@TempData["page"].Equals("revisions")"><i class="bi bi-clock-history" data-bs-toggle="tooltip" data-bs-placement="right" title="Revisons"></i></a>

Conversation spelling at

azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Revisions.cshtml

Line 36 in 1990a3f

<a type="button" class="btn btn-lg btn-link mb-2" asp-page="Conversation" asp-route-id="@Model.Review.Id"><i class="bi bi-chat-left-dots" data-bs-toggle="tooltip" data-bs-placement="right" title="Conversiations"></i></a>

Revision spelling at

azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Samples.cshtml

Line 36 in 1990a3f

<a type="button" class="btn btn-lg btn-link mb-2" data-bs-toggle="offcanvas" data-bs-target="#samplesRevisions-context" aria-controls="samplesRevisions-context"><i class="bi bi-clock-history" data-bs-toggle="tooltip" data-bs-placement="right" title="Revisons"></i></a>

Conversation spelling at

azure-sdk-tools/src/dotnet/APIView/APIViewWeb/Pages/Assemblies/Samples.cshtml

Line 37 in 1990a3f

<a type="button" class="btn btn-lg btn-link mb-2" asp-page="Conversation" asp-route-id="@Model.Review.Id"><i class="bi bi-chat-left-dots" data-bs-toggle="tooltip" data-bs-placement="right" title="Conversiations"></i></a>

🙃Seems English language is not my strong suit.

<a type="button" class="btn btn-lg btn-link mb-2" data-bs-toggle="offcanvas" data-bs-target="#apiRevisions-context" aria-controls="apiRevisions-context"><i class="bi bi-clock-history" data-bs-toggle="tooltip" data-bs-placement="right" title="Revisions"></i></a>
<a type="button" class="btn btn-lg btn-link mb-2" asp-page="Conversation" asp-route-id="@Model.ReviewContent.Review.Id"><i class="bi bi-chat-left-dots" data-bs-toggle="tooltip" data-bs-placement="right" title="Conversations"></i>
@if (Model.ReviewContent.ActiveConversationsInActiveAPIRevision > 0)
{
var count = (Model.ReviewContent.ActiveConversationsInActiveAPIRevision > 10) ? "9+" : $"{Model.ReviewContent.ActiveConversationsInActiveAPIRevision}";
Expand Down