Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass valid original artifact file name in request to APIView #7988

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

praveenkuttappan
Copy link
Member

Original file path is incorrect in request to APIView when token file is already generated. This will become an issue when attempting to rebuild existing reviews after the parser is upgraded to a newer version. Common script also uses incorrect path to find the token file if artifact name and package name are different. For e.g. JS package name is @azure/core-http and artifact name is azure-core-http. Currently we are looking for file within in the path @azure/core-http instead of azure-core-http.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Apr 2, 2024
@praveenkuttappan praveenkuttappan self-assigned this Apr 2, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@praveenkuttappan
Copy link
Member Author

/check-enforcer override

@praveenkuttappan praveenkuttappan merged commit b5a93d7 into Azure:main Apr 2, 2024
13 of 15 checks passed
@praveenkuttappan praveenkuttappan deleted the apiview_bug_fix branch April 2, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants