Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata_customized_docs.json: add spec dir sturcture, api versions and branches, breaking changes deep dive; remove avocado as it is obsolete #8029

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Apr 6, 2024

… and branches, breaking changes deep dive; remove avocado as it is obsolete
@konrad-jamrozik konrad-jamrozik requested a review from raych1 as a code owner April 6, 2024 02:39
@konrad-jamrozik konrad-jamrozik changed the title Update metadata_customized_docs.json: add dir sturcture, api versions and branches, breaking changes deep dive; remove avocado as it is obsolete Update metadata_customized_docs.json: add spec dir sturcture, api versions and branches, breaking changes deep dive; remove avocado as it is obsolete Apr 6, 2024
},
"pr-brch-deep.md": {
"title": "Breaking Changes process deep dive",
"url": "https://eng.ms/docs/products/azure-developer-experience/design/specs-pr-guides/pr-brch-deep"
Copy link
Contributor Author

@konrad-jamrozik konrad-jamrozik Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raych1 are links from eng.ms/docs going to work? If not, maybe from the sources, like e.g. https://dev.azure.com/azure-sdk/internal/_git/azure-sdk-docs-eng.ms?path=/docs/design/api-specs-pr/api-versions-and-branches.md

?

Here:

I found this:

Capability of this bot

This bot can provide general QA by searching through a knowledge base that includes documents from three sources:

Azure SDK documents available at the engineering hub site
TypeSpec documents available at https://github.com/azure/typespec-azure
Some markdown documents from a customized list

I guess this means there is no need to explicitly include anything from https://eng.ms/docs/products/azure-developer-experience as the bot should slurp all the docs there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konrad-jamrozik
You are correct. The documents under eng.ms/docs are added to the document source of the bot by default. There is no need to add them to customized docs list. The other hand, the document in the customized list must be publicly accessible. Otherwise, the pipeline cannot fetch it.

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit 963a492 into main Apr 16, 2024
4 checks passed
@konrad-jamrozik konrad-jamrozik deleted the konrad-jamrozik-patch-1 branch April 16, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants