Pass pipeline vnet to live test arm templates #8452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
weshaggard
reviewed
Jun 14, 2024
weshaggard
approved these changes
Jun 14, 2024
mikeharder
approved these changes
Jun 14, 2024
benbp
force-pushed
the
benbp/netiso-vnet-parameter
branch
from
ef521c3 to
cf9346a
Compare
|
The following pipelines have been queued for testing: |
This was referenced Jun 17, 2024
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jun 17, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8452 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Ben Broderick Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some azure resources (sql) cannot be accessed by VMs in a vnet even if they have public access enabled. In these cases we have to set up the vnet rules in the arm template at deploy time (instead of via azure policy).
See for example: Azure/azure-sdk-for-java#40639