Convert remaining packages which necessitate 1es-templates/esrp release #8460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osable yml. time to see how this thing performs
…e. I'm thinking the 1es templates cant quite hack it
scbedd
changed the title
scbedd
requested review from
catalinaperalta,
weshaggard,
praveenkuttappan,
maririos,
raych1,
tadelesh,
qiaozha,
MaryGao and
a team
as code owners
|
/check-enforcer override The |
weshaggard
reviewed
Jun 18, 2024
weshaggard
reviewed
Jun 18, 2024
weshaggard
approved these changes
Jun 18, 2024
|
Ray recently deleted |
|
Will do so. Needed to get in here to make the SemVer changes anyway. |
…ument passed to the publish stage
|
My claim is that
Just going to merge this and then deal with the fallout. |
|
/check-enforcer overrde |
|
For help using check enforcer, see https://aka.ms/azsdk/checkenforcer Available commands:
If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run |
|
|
||
| - task: PowerShell@2 | ||
| inputs: | ||
| filePath: '$(Build.SourcesDirectory)/eng/scripts/determine-release-tag.ps1' |
There was a problem hiding this comment.
This file doesnt match the new one being added in the PR. Seems like the file name should be determine-js-release-tag.ps1
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following yml are associated with projects that need to publish to npmjs.org. This PR simply removes each's individual
releasestage in favor of a single added stage. After walking each package withinazure-sdk-tools, I believe these are the only remaining builds that must become 1es compliant.tools/sdk-generation-pipeline/ci.ymlDeleted inmaintools/apiview/parsers/js-api-parser/ci.ymlOnly publishes to internal feedeng/pipelines/templates/stages/archetype-autorest-preview.ymlThis yml is referenced nowhere that I can tell. Not from another template and not direct from a build definition.FOR REVIEWERS I advise disabling whitespace diffs it massively simplifies looking at what this PR does. Much more re-use than code deletion.
Related to #7941