Pass condition to a few analyze eng/common checks
#8597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
approved these changes
Jul 10, 2024
|
The following pipelines have been queued for testing: |
This was referenced Jul 10, 2024
scbedd
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jul 10, 2024
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#8597 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) Co-authored-by: Scott Beddall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python had a nightly
analyzefailure that had me really confused. The issue was that one of the eng/common steps which set the daily dev build variable skipped due to a defaultsucceeded()condition when a step above it unexpectedly failed.I walked the rest of the
analyzesteps in Python, and identified a few more where a custom condition can be provided to allowsucceededOrFailed()to be passed. This way all the enforcement runs on a given analyze job.Once this PR merges I'll take advantage of it on python side and ensure the issue that hit @kristapratico is avoided in the future.