Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More compatibility changes for expandable public builds #8754

Merged
merged 8 commits into from
Aug 7, 2024
Merged

More compatibility changes for expandable public builds #8754

merged 8 commits into from
Aug 7, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Aug 1, 2024 •
edited
Loading

Includes:

  • Adding a new property DependentPackages that can be populated by each language team in Language-Settings
    • This allow us to "customize" what packages appear while generating the set of PR Package properties. Language Settings Change
  • Various updates to verify readmes, changelogs, and api changes

@praveenkuttappan this changes the DetectApi-Changes to be powered based off the files in PackageInfo, NOT the artifact list. This is the only change, and as far as I can tell this is transparent / I just need to update callsite to not include the extra parameter for Artifacts. Thoughts?

Example build using these changes

Package-Properties example:

//cat .\PackageInfo\azure-core.json
{
  "Name": "azure-core",
  "Version": "1.31.0",
  "DevVersion": null,
  "DirectoryPath": "sdk/core/azure-core",
  "ServiceDirectory": "core",
  "ReadMePath": "sdk/core/azure-core/README.md",
  "ChangeLogPath": "sdk/core/azure-core/CHANGELOG.md",
  "Group": null,
  "SdkType": "client",
  "IsNewSdk": true,
  "ArtifactName": "azure-core",
  "ReleaseStatus": "Unreleased",
  "DependentPackages": [
    "sdk/storage/azure-storage-blob",
    "sdk/servicebus/azure-servicebus",
    "sdk/eventhub/azure-eventhub",
    "sdk/tables/azure-data-table",
    "sdk/appconfig/azure-appconfig",
    "sdk/keyvault/azure-keyvault-keys",
    "sdk/identity/azure-identity",
    "sdk/core/azure-mgmt-core",
    "sdk/core/azure-core-experimental",
    "sdk/core/azure-core-tracing-opentelemetry",
    "sdk/core/azure-core-tracing-opencensus",
    "sdk/cosmos/azure-cosmos",
    "sdk/ml/azure-ai-ml",
    "sdk/ai/azure-ai-documentintelligence",
    "sdk/ai/azure-ai-inference",
    "sdk/ai/azure-ai-textanalytics",
    "sdk/ai/azure-ai-doctranslation",
    "sdk/compute/azure-mgmt-compute",
    "sdk/communication/azure-communication-chat",
    "sdk/communication/azure-communication-identity"
  ]
}

@scbedd
more compatibility with expanding/contracting packages. add ability f…
e66324b 
…or packages to have DependentPackages that must be included in the set of packages that should be built given a changeset
@scbedd scbedd self-assigned this Aug 1, 2024
@scbedd scbedd requested a review from a team as a code owner August 1, 2024 19:10
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd
Copy link
Member Author

scbedd commented Aug 7, 2024 •
edited
Loading

@praveenkuttappan I've renamed which artifact path you pull from. Will get this into public PR to verify that no functionality is broken in main in the language repos. It should work just fine for python. I'll probably need to make a small change to each sync pr to remove the -ArtifactList parameter, but that's nbd.

This was referenced Aug 7, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 7, 2024
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

praveenkuttappan
praveenkuttappan approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@scbedd
Copy link
Member Author

scbedd commented Aug 7, 2024

Looks good

👍 I'll ensure I see the same diffs for JS before merging (on a template run).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

scbedd added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 7, 2024
@azure-sdk @scbedd @weshaggard
Sync eng/common directory with azure-sdk-tools for PR 8754 (#30677)
1ea51f7 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8754 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Scott Beddall <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
@scbedd scbedd merged commit 9b208af into main Aug 7, 2024
12 checks passed
@scbedd scbedd deleted the addition-pr-updates branch August 7, 2024 23:41
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scbedd @azure-sdk @weshaggard @praveenkuttappan