Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request automation feedback #8878

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Pull Request automation feedback #8878

merged 3 commits into from
Aug 29, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Aug 23, 2024

From @hallipr dealing with rust implementation.

@scbedd scbedd requested a review from a team as a code owner August 23, 2024 23:25
@scbedd scbedd self-assigned this Aug 23, 2024
@scbedd scbedd mentioned this pull request Aug 23, 2024
Closed
@scbedd
Copy link
Member Author

scbedd commented Aug 27, 2024 •
edited
Loading

I have identified the issue. azure-sdk-for-android is out of alignment with azure-sdk-tools as far as eng/common/scripts/common.ps1. Doing a manual comparison across the repos and finding the gaps.

EDIT: one additional:

@scbedd scbedd mentioned this pull request Aug 27, 2024
Merged
@scbedd scbedd force-pushed the handle-rust-pr-discoveries branch 2 times, most recently from c2979a1 to dbc4122 Compare August 27, 2024 17:42
@weshaggard
Copy link
Member

I have identified the issue. azure-sdk-for-android is out of alignment with azure-sdk-tools as far as eng/common/scripts/common.ps1. Doing a manual comparison across the repos and finding the gaps.

EDIT: one additional:

I've just triggered a manual sync run https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4086664&view=logs&j=96791242-dbf3-587e-3a06-ae5af5c1a705&t=545ac0b0-0fa6-5135-76aa-19ebc03770c9 to try and make sure eng/common is not out-of-sync for anything else.

@scbedd scbedd force-pushed the handle-rust-pr-discoveries branch from dbc4122 to f863bc2 Compare August 27, 2024 22:15
@scbedd
Apply a few changes to Get-PRPackageProperties to make it more custom…
4cb7a13 
…izable for our users.

Remove wonky gap + extra spacing that should pass the patch application process now that we've manually aligned common.ps1
@scbedd scbedd force-pushed the handle-rust-pr-discoveries branch from f863bc2 to 4cb7a13 Compare August 27, 2024 22:27
@scbedd
Copy link
Member Author

scbedd commented Aug 27, 2024

I just reverted this to identical to the version from main + my updates. STILL no dice on this diff. Gonna have to manually repro the diff and discover how can I patch this.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

I just reverted this to identical to the version from main + my updates. STILL no dice on this diff. Gonna have to manually repro the diff and discover how can I patch this.

I missed merging the android update yesterday. I did this morning and retried your pipeline and the patching worked this round.

@weshaggard weshaggard mentioned this pull request Aug 28, 2024
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
scbedd added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 29, 2024
@azure-sdk @scbedd
Sync eng/common directory with azure-sdk-tools for PR 8878 (#30945)
92f2b19 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#8878 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Scott Beddall <[email protected]>
@scbedd
Copy link
Member Author

scbedd commented Aug 29, 2024

/check-enforcer evaluate

@scbedd scbedd merged commit 2489a64 into main Aug 29, 2024
12 checks passed
@scbedd scbedd deleted the handle-rust-pr-discoveries branch August 29, 2024 01:15
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scbedd @weshaggard @azure-sdk