080624.01/comment and diff navigation

[chidozieononiwu]

• Add feature for navigating comments and diffs on the review page.
  

[praveenkuttappan]

Let's discuss about this feature. I would prefer to see next and previous comment button like in the old system. Or even a button that becomes visible when you roll over the mouse. It does not feel like a right fit to put this in review page options panel.

[chidozieononiwu]

Let's discuss about this feature. I would prefer to see next and previous comment button like in the old system. Or even a button that becomes visible when you roll over the mouse. It does not feel like a right fit to put this in review page options panel.

The advantage here is that the user does not need to find the first comment on the page before beginning to navigate. In some cases the first comment might be out of the view port. Also implementing a similar UI for diff is a bit cumbersome so I tough its best to put all the navigation UI in one place.

[praveenkuttappan]

Let's discuss about this feature. I would prefer to see next and previous comment button like in the old system. Or even a button that becomes visible when you roll over the mouse. It does not feel like a right fit to put this in review page options panel.

The advantage here is that the user does not need to find the first comment on the page before beginning to navigate. In some cases the first comment might be out of the view port. Also implementing a similar UI for diff is a bit cumbersome so I tough its best to put all the navigation UI in one place.

I see your point. One problem with this approach is that when a user decides to hide the right-side panel to get more real estate then they won't be able to use this feature. So, they will be forced to use the panel to jump to next diff or comment. Can we a projected button at the top when scrolling over to go to first comment or diff similar to the icon button you had earlier added in revisions page.

[maririos]

I talked offline with @chidozieononiwu that we can leave the diff arrows only on the side panel. The comment ones can happen both in the comments and in the side panel. Could you update the images with that change?

Looking at the imagines, what do you think about swapping the order to show prev on the left and next in the right? I was looking at some UI designs and they mentioned to put next on the right and to give only one button preference. https://fluent2.microsoft.design/components/web/react/button/usage

[chidozieononiwu]

I talked offline with @chidozieononiwu that we can leave the diff arrows only on the side panel. The comment ones can happen both in the comments and in the side panel. Could you update the images with that change?

Looking at the imagines, what do you think about swapping the order to show prev on the left and next in the right? I was looking at some UI designs and they mentioned to put next on the right and to give only one button preference. https://fluent2.microsoft.design/components/web/react/button/usage

Resolved