Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apiview-js-parser] more bug fixes #9184

Merged
merged 13 commits into from
Oct 25, 2024
Merged

[apiview-js-parser] more bug fixes #9184

merged 13 commits into from
Oct 25, 2024

Conversation

jeremymeng
Copy link
Member

@jeremymeng jeremymeng commented Oct 16, 2024 •
edited
Loading

  • skipDiff for dependency header
  • attach pre-release tags with their related lines
  • add spaces before | and &
  • add export const for constants
  • fix type reference for multi-line code excerpt
  • fix contextual keyword kind in property/method signature
  • hide enum members from navigation list
  • create a TypeName token for type parameter
  • replace export declare enum with export enum
  • group items by their kinds and add an order to the groups

@jeremymeng
[apiview-js-parser] more bug fixes
103df86 
- skipDiff for dependency header
- attach pre-release tags with their related lines
@jeremymeng jeremymeng requested a review from maorleger as a code owner October 16, 2024 01:48
@jeremymeng
Merge remote-tracking branch 'upstream/main' into apiview-js-type-key…
e2753dc 
…word
@jeremymeng
Add export const for constants
02a9bc7
@jeremymeng
Fix the whitespace issue
1e0288b 
We need to add space to the previous token in the same line, not just the
previous token in the current except
@jeremymeng
- fix type reference for multi-line code excerpt
b6a0a83 
- fix spacing around | and &
@jeremymeng
- fix another whitespace case before punctaion
baed354 
- enable sourceMap for debugging
@jeremymeng
- is keyword also needs leading whitespace
7130d8c
@jeremymeng
- fix contextual keyword in proeprty/method signature
951f2e5
@jeremymeng
- Refactor to pass item to splitAndBuild so that we can use more …
dfdaadb 
…information in the api item
@jeremymeng
- hide enum members from navigation list
bd30157
@jeremymeng
- create a TypeName token for type parameter
933871e 
- fix type parameter case in members
@jeremymeng
- replace export declare enum with export enum
820e7fc
@jeremymeng
- group items by their kinds
307c96f 
and add an oder to the groups
@jeremymeng jeremymeng merged commit bf41c7b into Azure:main Oct 25, 2024
11 checks passed
@jeremymeng jeremymeng deleted the apiview-js-type-keyword branch October 25, 2024 19:22
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenkuttappan praveenkuttappan praveenkuttappan approved these changes

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremymeng @praveenkuttappan