Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support override of powershell module feeds #9392

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

benbp
Copy link
Member

@benbp benbp commented Nov 15, 2024

Adding an override list of ps modules we want to redirect to our devops mirror feed.

Also simplified the module existence check (still thread safe), but I'm thinking that maybe the double existence check was there so we wouldn't have a giant lock request backlog if a ton of threads all do a module check at the same time (given it takes 1 sec to do the check if it's behind the lock). @mikeharder any recollection on this? From #6521

@benbp benbp requested a review from a team as a code owner November 15, 2024 22:34
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Nov 15, 2024
@benbp benbp self-assigned this Nov 15, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a reasonable middle ground until we need to change. I know we could pull the versions available from the feed, but there's something to be said for the determinism of having the <package>;<version> key always resolve to a feed we expect.

@benbp
Copy link
Member Author

benbp commented Nov 20, 2024

@scbedd @weshaggard latest update adds fallback support, so we can query multiple package feeds until one succeeds.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member Author

benbp commented Nov 21, 2024

@scbedd @weshaggard added another commit to unregister the repository after install, it's causing some weird overlap issues with dotnet tool install later in the pipelines, possibly b/c the url format has to be slightly different. Still trying to figure out what's actually going on here.

Installing test-proxy version 1.0.0-dev.20241101.1
Unhandled exception: NuGet.Protocol.Core.Types.FatalProtocolException: Failed to fetch results from V2 feed at 'https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-tools/nuget/v2/FindPackagesById()?id='azure.sdk.tools.testproxy'&semVerLevel=2.0.0' with following message : Response status code does not indicate success: 401 (Unauthorized - No local versions of package 'azure.sdk.tools.testproxy'; please provide authentication to access versions from upstream that have not yet been saved to your feed. (DevOps Activity ID: D6280451-EFE3-48AA-BF7C-7A31FBB5EF7E)).
---> System.Net.Http.HttpRequestException: Response status code does not indicate success: 401 (Unauthorized - No local versions of package 'azure.sdk.tools.testproxy'; please provide authentication to access versions from upstream that have not yet been saved to your feed. (DevOps Activity ID: D6280451-EFE3-48AA-BF7C-7A31FBB5EF7E)).
at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp added a commit to Azure/azure-sdk-for-js that referenced this pull request Nov 21, 2024
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#9392 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <[email protected]>
@benbp benbp enabled auto-merge (squash) November 21, 2024 21:47
@benbp benbp merged commit 86c24f0 into Azure:main Nov 21, 2024
12 checks passed
@benbp benbp deleted the benbp/powershell-mirror branch November 21, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants