-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support override of powershell module feeds #9392
Conversation
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable middle ground until we need to change. I know we could pull the versions available from the feed, but there's something to be said for the determinism of having the <package>;<version>
key always resolve to a feed we expect.
@scbedd @weshaggard latest update adds fallback support, so we can query multiple package feeds until one succeeds. |
a2b3696
to
fc5082a
Compare
The following pipelines have been queued for testing: |
@scbedd @weshaggard added another commit to unregister the repository after install, it's causing some weird overlap issues with
|
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9392 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <[email protected]>
Adding an override list of ps modules we want to redirect to our devops mirror feed.
Also simplified the module existence check (still thread safe), but I'm thinking that maybe the double existence check was there so we wouldn't have a giant lock request backlog if a ton of threads all do a module check at the same time (given it takes 1 sec to do the check if it's behind the lock). @mikeharder any recollection on this? From #6521