Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in diff when end of context line has diff #9396

Merged

Conversation

praveenkuttappan
Copy link
Member

Diff is showing added line as removed when diff is in end of context line. Empty lines from untouched classes are not removed from node and tree view if parser doesn't set empty lines as related to the node line.

@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Nov 18, 2024
@praveenkuttappan praveenkuttappan self-assigned this Nov 18, 2024
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this?

@praveenkuttappan
Copy link
Member Author

Can we add a test for this?

Sure. I will submit a separate PR to add it.

@praveenkuttappan praveenkuttappan merged commit b190443 into Azure:main Nov 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants