Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Yml Extraction #9493

Merged
merged 8 commits into from
Dec 12, 2024
Merged

Optimize Yml Extraction #9493

merged 8 commits into from
Dec 12, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Dec 6, 2024 •
edited
Loading

Attempt dos. Creating this PR to avoid the merge conflicts on the original PR: #9332

@scbedd scbedd self-assigned this Dec 6, 2024
@scbedd scbedd requested a review from a team as a code owner December 6, 2024 23:38
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Dec 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but looks good otherwise.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@scbedd
Copy link
Member Author

scbedd commented Dec 12, 2024 •
edited
Loading

Discovered an issue with the null check.

On stricter modes we fail because the path isn't defined. Latest commit should be a safe fix.

# works
Set-StrictMode -Version 4

if (-not (Test-Path variable:script:DefinitionTest)) {
    $script:DefinitionTest = 1
}

if (Test-Path variable:script:DefinitionTest){
    Write-Host "Hello $script:DefinitionTest"
}

@scbedd scbedd merged commit 8ef71ab into Azure:main Dec 12, 2024
12 checks passed
@maorleger maorleger mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@weshaggard weshaggard weshaggard approved these changes

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🤖🧠
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scbedd @azure-sdk @benbp @weshaggard