-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out Exclude Paths for PR Pipelines #9649
Filter out Exclude Paths for PR Pipelines #9649
Conversation
The following pipelines have been queued for testing: |
eng/common/pipelines/templates/steps/save-package-properties.yml
Outdated
Show resolved
Hide resolved
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#9649 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <[email protected]>
* Filter out Excludes for PR Pipelines * Updates for feedback
@scbedd and @weshaggard
These are the common changes required to filter out PackageInfo generation by what should be excluded from the pull request pipelines. This is the example in Python, which excludes
sdk/cosmos
. The unfortunate thing here is that we can't access the pr->paths->exclude meaning this needs to be duplicated. Because of the default in the save-package-properties.yml nothing will break if the ExcludePaths aren't plumbed through. The only downside here is that wildcards aren't accepted but then again, most excludes in yml files aren't wildcarded.I'd created a draft PR in Python to test these changes. Notice that the PR had changes in Cosmos and Template. This is the test run and if you notice, Cosmos no longer has a PackageInfo file in the artifacts and it's no longer running tests for azure-cosmos in the pullrequest pipeline. The diff.json for the PR is below which correctly has ExcludePaths.
Last but not least, the test PR in Python also shows where ExcludePaths would have to be plumbed through. Once this gets reviewed and pushed out to the repositories, I'll end up making those changes in Python. For Java, we'll have more excludes, mostly for Track1 libraries, Cosmos, resourcemanagerhybrid and possibly Spring.
Fixes #9634