Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up server errors to client. #9667

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

chidozieononiwu
Copy link
Member

Allow http interceptor to return errors in production as its needed for other functioning of the app

@maririos maririos requested a review from Copilot January 21, 2025 19:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@maririos
Copy link
Member

as its needed for other functioning of the app

Curious. is this user facing or just internal.

@chidozieononiwu
Copy link
Member Author

as its needed for other functioning of the app

Curious. is this user facing or just internal.

Am not sure what you mean. I tried to hide the errors from console, but the browser does not obey it in all instances. So best we just address error rather than hiding it. Plus in some cases the error is legit. In this case this instance 401 authorized error that triggers redirect to login page.

@maririos
Copy link
Member

as its needed for other functioning of the app

Curious. is this user facing or just internal.

Am not sure what you mean. I tried to hide the errors from console, but the browser does not obey it in all instances. So best we just address error rather than hiding it. Plus in some cases the error is legit. In this case this instance 401 authorized error that triggers redirect to login page.

The fact that APIView is still all internal then it should be ok.

@chidozieononiwu chidozieononiwu merged commit d679ec9 into Azure:main Jan 21, 2025
10 checks passed
swathipil pushed a commit to swathipil/azure-sdk-tools that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants