Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopted 1es common template #9724

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Adopted 1es common template #9724

merged 2 commits into from
Jan 29, 2025

Conversation

raych1
Copy link
Member

@raych1 raych1 commented Jan 28, 2025

  • Adopted the 1es pipeline template
  • Published all the artifacts and logs to the pipeline artifacts
  • Moved this pipeline yml file to stages folder

@raych1 raych1 self-assigned this Jan 28, 2025
@raych1 raych1 requested a review from a team as a code owner January 28, 2025 19:55
@raych1 raych1 added Central-EngSys This issue is owned by the Engineering System team. Automation Tool labels Jan 28, 2025
@raych1
Copy link
Member Author

raych1 commented Jan 28, 2025

It would be good to suppress these warnings or ignoring the steps since this pipeline is mainly to generate SDK code. @benbp, do you have any idea how to do that if we should do it?
image
Here is a sample run

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp
Copy link
Member

benbp commented Jan 28, 2025

@raych1 the github related ones should go away soon as they are addressing that issue. For the others, either the underlying issues can be fixed (component governance), or we can add skips to the top level 1es config. We haven't been able to eliminate every warning, as each one takes its own investigation.

@raych1
Copy link
Member Author

raych1 commented Jan 29, 2025

@raych1 the github related ones should go away soon as they are addressing that issue. For the others, either the underlying issues can be fixed (component governance), or we can add skips to the top level 1es config. We haven't been able to eliminate every warning, as each one takes its own investigation.

I don't see any special configuration needs to make for spec repo since this pipeline is bound to the spec repo except this change. Do you have any concern?

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Jan 29, 2025
@raych1 raych1 merged commit 174e915 into main Jan 29, 2025
22 checks passed
@raych1 raych1 deleted the user/raych1/use-1es-template branch January 29, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation Tool Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants