-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a more specific selector than control-plane: controller-manager #4277
Comments
The challenge here is that we have to delete the deployment in order to change this field. We can do this with a Helm hook, but given it's a bit involved I'm going to kick this out to 2.11 for now. |
The actual error is:
Note that this happens even if the deployment mode is |
Describe the current behavior
We use the kubebuilder default selector
control-plane: controller-manager
, which many other projects may also use. We should be good citizens and at least in theory support being installed into the same namespace, but if we're using the same labels as other deployments webhooks and other selectors may get confused.See #4274 as an example.
Describe the improvement
Use a label unique to ASO.
The text was updated successfully, but these errors were encountered: