Adopt ASO-specific label to replace default control-plane: controller-manager

[bingikarthik]

What this PR does

Closes #4277

Current Behavior:
The kubebuilder default label control-plane: controller-manager is currently used. This label is common across many projects, which can lead to potential conflicts, especially when multiple deployments or webhooks exist in the same namespace. Such conflicts may cause misrouting of resources and selectors, impacting functionality.

Improvement:
This PR introduces a unique label specific to ASO, ensuring better namespace coexistence and reducing the risk of conflicts with other deployments. By aligning with best practices, this change improves ASO's compatibility and coexistence within shared Kubernetes environments.

Impact:

• Avoids label conflicts with other projects.
• Supports installation alongside other controllers in the same namespace.
• Enhances stability and maintainability of deployments using ASO.

This update addresses potential selector misconfigurations and promotes more robust operations in multi-controller setups.

How does this PR make you feel?

Checklist

• this PR contains documentation
• this PR contains tests
• this PR contains YAML Samples

[matthchr]

We are interested in doing something like this, but as called out in the linked issue #4277, just making this doesn't work I don't think because it can't be changed on existing deployments. I think we'll need something more involved, though I also need to check if changing the deployment mode to Recreate makes this any easier.

[bingikarthik]

Yes, agree this won't apply on existing deployments! To apply probably deployment strategy to have: Recreate(i.e., need to rollout following PR: #4466)

[matthchr]

I tested with strategy Recreate and it still doesn't work. The only way is to delete and recreate the deployment. See discussion on #4277.

I would like to do this, but we'll need to be careful about it, and I think the change is more involved than what you have done because the change as-proposed won't allow for Helm chart upgrades.

This means that (for now) we can't take this change as-is.

Can you expand more on where you ran into this issue? Even though I'd like to see this get fixed, in practice it shouldn't cause much issue if you install ASO into its own namespace (which is recommended anyway). Can you expand more on what you had it collide with? Was the issue ASOv1?

[bingikarthik]

in practice it shouldn't cause much issue if you install ASO into its own namespace (which is recommended anyway)

Agreed on this point! We're already following a similar approach. This is more of a nice-to-have feature than a must-have. In case someone deploys a controller with control-plane: controller-manager labels in the same namespace where ASO is running, it could lead to a conflict. We can address this issue in the future. Closing the PR for now.