Add support for ServiceBus AuthorizationRules #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
force-pushed
the
feature/servicebus-secrets
branch
from
fb0c0ef to
56f953f
Compare
matthchr
requested changes
May 17, 2023
v2/api/servicebus/customizations/namespaces_authorization_rule_extensions.go
Outdated
Show resolved
Hide resolved
v2/samples/servicebus/v1api/v1api20210101preview_namespacesauthorizationrule.yaml
Outdated
Show resolved
Hide resolved
v2/samples/servicebus/v1api/v1api20210101preview_namespacesauthorizationrule.yaml
Outdated
Show resolved
Hide resolved
super-harsh
reviewed
May 18, 2023
v2/samples/servicebus/v1api/v1api20210101preview_namespacesauthorizationrule.yaml
Outdated
Show resolved
Hide resolved
super-harsh
reviewed
May 18, 2023
| metadata: | ||
| name: aso-namespace-rule | ||
| namespace: default | ||
| spec: |
There was a problem hiding this comment.
We also want to mention Owner field in spec
super-harsh
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for ServiceBus AuthorizationRules, including secrets.
Closes #2708
Special notes for your reviewer:
There was more to this than anticipated.
How does this PR make you feel:
If applicable: