Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document upcoming 2.2.0 breaking change #3036

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Document upcoming 2.2.0 breaking change #3036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dccb651
Document upcoming 2.2.0 breaking change
matthchr May 31, 2023
6463800
Merge branch 'main' into feature/breaking-change-docs
theunrepentantgeek Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/hugo/content/guide/breaking-changes/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ You can easily swap from a `v1beta` version to a `v1api` version by just replaci

## Released Breaking Changes

### Upcoming breaking changes
* AKS ManagedClusterServicePrincipalProfile.Secret will change from `string` to `genruntime.SecretReference`

### v2.1.0

Breaking changes are:
Expand Down
9 changes: 9 additions & 0 deletions docs/hugo/content/guide/breaking-changes/breaking-changes-v2.1.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,12 @@ allowing references to secrets only if the secret is in the same namespace as th
This was a security issue which we had to close.

See [#2919](https://github.com/Azure/azure-service-operator/pull/2919)

## Upcoming breaking changes

### AKS ManagedClusterServicePrincipalProfile.Secret will change from `string` to `genruntime.SecretReference`

We realized that this field contains a secret and as such _should not be specified_. Secrets should not appear in plain
text in CRs. We will be making a breaking change in 2.2.0 to resolve this issue.

**In the meantime:** We strongly recommend you use managed identity (the default) for your clusters.