Support follow-symlinks SMB properties #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
|
Can we add a comment somewhere indicating how to set up and test this manually? That way if there is a bug or something at some point, we can easily follow those steps and debug |
|
I noticed there are some typos in your documentation - if you're okay with it, I can submit a PR to fix them. |
gapra-msft
approved these changes
Jul 20, 2023
nakulkar-msft
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way symlink following worked (followed in the traverser, then submitted to the plan file as the destination), the flag check may simply be disabled with the consequence being that the actual destination file is checked (in alignment with the suggested behaviour from the files team).
I still need to look into if we can run the test suite as an administrator, as it would be required for testing this functionality, since creating Symlinks on Windows requires admin permissionsNo, we can't test this automatically unless we self-host a Windows agent.