Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotating logger #2446

Merged
merged 6 commits into from
Nov 28, 2023
Merged

Rotating logger #2446

merged 6 commits into from
Nov 28, 2023

Conversation

nakulkar-msft
Copy link
Contributor

@nakulkar-msft nakulkar-msft commented Nov 9, 2023 •
edited by gapra-msft
Loading

Resolves #2213

gapra-msft
gapra-msft reviewed Nov 13, 2023
View reviewed changes
common/rotatingWriter.go

if atomic.LoadInt32(&w.currentSuffix) > suffix {
// This log has already been rotated.
return nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a valid situation? trying to rotate an already rotated log?

@gapra-msft gapra-msft linked an issue Nov 17, 2023 that may be closed by this pull request
Feature Request: Log file splitting\rotating. #2213
Closed
siminsavani-msft
siminsavani-msft approved these changes Nov 22, 2023
View reviewed changes
@nakulkar-msft nakulkar-msft merged commit abd185c into dev Nov 28, 2023
@nakulkar-msft nakulkar-msft deleted the nakulkar/private/logger1 branch December 5, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gapra-msft gapra-msft gapra-msft approved these changes

@siminsavani-msft siminsavani-msft siminsavani-msft approved these changes

@adreed-msft adreed-msft Awaiting requested review from adreed-msft adreed-msft is a code owner

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

@tasherif-msft tasherif-msft Awaiting requested review from tasherif-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Log file splitting\rotating.
3 participants
@nakulkar-msft @gapra-msft @siminsavani-msft