-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Code Change] AzCopy Error Improvements #2647
Conversation
@siminsavani-msft linked are active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to update your branch since I've included the fix for the failing test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have E2E testcases to verify this behavior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, questions about testing, though.
Another thought-- Does this catch things like a job failing after it begins running? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we added tests for list, remove as we discussed ?
Was working on other PRs, just added now! |
Mostly catches the service side errors and spits out related shorthand error code URLs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added Error Code URL as seen below, proposed by Daniel
azcopy copy "sourceurl" "destinationurl"
Added error code URLs to commonly used commands: copy, sync, remove, and list.