[Storage Explorer] _token_refresh_source type change #2710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dphulkar-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
…into az-28320197
…into az-28320197
adreed-msft
requested changes
Jun 10, 2024
gapra-msft
reviewed
Jun 10, 2024
gapra-msft
reviewed
Jun 10, 2024
…into az-28320197
…into az-28320197
gapra-msft
reviewed
Jun 11, 2024
|
@dphulkar-msft, let's prioritize this PR, this is the last item we need to complete before the patch release. |
gapra-msft
reviewed
Jun 11, 2024
vibhansa-msft
approved these changes
Jun 12, 2024
gapra-msft
approved these changes
Jun 12, 2024
adreed-msft
reviewed
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://msazure.visualstudio.com/One/_workitems/edit/28320197
Error while unmashalling OAuthTokenInfo._token_refresh_source as the type has been changed from string to uint8 and the field is received as string type from user.
Bug-fix: Implemented two interfaces json.Marshaler and json.Unmarshaler on AutoLoginType to marshal and unmarshal it as a string.
PR reference where _token_refresh_source has been changes from string to uint8