Device Code Migration to AzIdentity Track 2 #2747
Conversation
…run them when expected
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…torage-azcopy into az-releasePipeline
…orage-azcopy into gapra/deviceLogin
dphulkar-msft
requested review from
dphulkar-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
| return strings.Join(a.RawStdout(), "\n") | ||
| } | ||
|
|
||
| func RunAzCopyLoginLogout(a Asserter, verb AzCopyVerb) AzCopyStdout { |
There was a problem hiding this comment.
This is also interesting to me-- Is there a reason to prefer a separate function over integrating with RunAzCopy?
There was a problem hiding this comment.
I did this mostly because login needs some interactive stdout, whereas RunAzCopy is just reading the stdout. There is probably a clean way to integrate it with the other method. this can be cleaned this up after the PR is merged
| @@ -337,8 +342,10 @@ func RunAzCopy(a ScenarioAsserter, commandSpec AzCopyCommand) (AzCopyStdout, *Az | |||
| 0, command.ProcessState.ExitCode()) | |||
|
|
|||
| a.Cleanup(func(a ScenarioAsserter) { | |||
| UploadLogs(a, out, stderr, DerefOrZero(commandSpec.Environment.LogLocation)) | |||
| _ = os.RemoveAll(DerefOrZero(commandSpec.Environment.LogLocation)) | |||
| if !commandSpec.Environment.ManualLogin { | |||
There was a problem hiding this comment.
This also interests me-- I suspect this is to prevent capturing the login token, but, could we not filter that out?
There was a problem hiding this comment.
Currently the new e2e test framework is designed such that each of the scenarios creates a new temp log location. When you log in it creates a file in the log location and we want that log in to be the same across all e2e test framework logs, so we avoid removing the log folder. There is probably a cleaner way to do this that we can look into during a cleanup PR.
gapra-msft
changed the title
gapra-msft
changed the title
Resolves #2361
Note: We need to test with personal accounts right now.