Improved some logging messages and --log-level NONE behavior #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dphulkar-msft
commented
Oct 28, 2024
•
dphulkar-msft
commented
- If --log-level is set to NONE it should not display the log file location message on the cmd prompt. (Applicable for copy, sync, jobs resume)
- We do support --log-level as DEBUG but the details of it are missing from the help command that we display.
- Corrected some logging message level.
…message on the cmd prompt
dphulkar-msft
requested review from
gapra-msft,
adreed-msft,
vibhansa-msft,
seanmcc-msft,
souravgupta-msft and
tanyasethi-msft
as code owners
gapra-msft
reviewed
Nov 11, 2024
gapra-msft
reviewed
Nov 11, 2024
gapra-msft
approved these changes
Nov 11, 2024
…into dphulkar/improveLogging
…ure-storage-azcopy into dphulkar/improveLogging
…into dphulkar/improveLogging
…into dphulkar/improveLogging
…into dphulkar/improveLogging
…ure-storage-azcopy into dphulkar/improveLogging
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
wonwuakpa-msft
approved these changes
Jan 6, 2025
…into dphulkar/improveLogging
|
@dphulkar-msft we should be good to merge this PR after you update the branch with main. |
…into dphulkar/improveLogging
…ure-storage-azcopy into dphulkar/improveLogging
…into dphulkar/improveLogging
wonwuakpa-msft
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.