[AppInsights] fixing SB result-reporting #2015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
reviewed
Nov 16, 2018
| @@ -139,7 +172,10 @@ public async Task ServiceBusRequestWithoutParent() | |||
| Assert.True(double.TryParse(request.Properties[LogConstants.FunctionExecutionTimeKey], out double functionDuration)); | |||
| Assert.True(request.Duration.TotalMilliseconds >= functionDuration); | |||
|
|
|||
| TelemetryValidationHelpers.ValidateRequest(request, operationName, operationId, parentId, LogCategories.Results); | |||
| Assert.DoesNotContain(request.Properties, p => p.Key == LogConstants.HttpMethodKey); | |||
There was a problem hiding this comment.
i think you validate it in the TelemetryValidationHelpers.ValidateRequest
lmolkova
approved these changes
Nov 16, 2018
brettsam
commented
Nov 16, 2018
|
|
||
| // Remove the Succeeded property as it's duplicated | ||
| request.Properties.Remove(LogConstants.SucceededKey); | ||
| } |
There was a problem hiding this comment.
FYI -- this part where we check the SucceededKey is the major change. It will be needed for Http as well.
There was a problem hiding this comment.
I wonder if we can prevent it from being set on properties at the first place. It's set in the AppInsightsLogger. but now it's needed because of microsoft/ApplicationInsights-dotnet-server#1038 anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2012.
Also re-adds
ISdkVersionProviderfrom the reverted Http tracking commit, as it's a better way for us to update the version in multiple places.