feat: use cert ready checker for webhook readiness #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
readyz-checker
branch
from
2179a45 to
7d33401
Compare
enj
approved these changes
Jan 26, 2023
Signed-off-by: Anish Ramasekar <[email protected]>
aramase
force-pushed
the
readyz-checker
branch
from
7d33401 to
6e74ec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anish Ramasekar [email protected]
Reason for Change:
Block readiness on the mutating webhook being registered. We can't use
mgr.GetWebhookServer().StartedChecker()yet, because that starts the webhook. But we also can't callAddReadyzCheckafterManager.Start. So we need a custom ready check that delegates to the real ready check after the cert has been injected and validator started.Requirements
Issue Fixed:
fixes #709
fixes #719
Please answer the following questions with yes/no:
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
Notes for Reviewers: