-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Bicep.IO package to Azure.Bicep.IO #16046
Conversation
Test this change out locally with the following install scripts (Action run 12696685953) VSCode
Azure CLI
|
Dotnet Test Results 78 files - 39 78 suites - 39 33m 25s ⏱️ - 16m 20s Results for commit 7289970. ± Comparison against base commit 4fff513. This pull request removes 1841 and adds 632 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
<PropertyGroup> | ||
<TargetFramework>net8.0</TargetFramework> | ||
<ImplicitUsings>enable</ImplicitUsings> | ||
<Nullable>enable</Nullable> | ||
<AssemblyName>Azure.Bicep.IO</AssemblyName> | ||
<RootNamespace>Bicep.IO</RootNamespace> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not change the root namespace to match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this over from
bicep/src/Bicep.Core/Bicep.Core.csproj
Lines 2 to 16 in 4fff513
<PropertyGroup> | |
<AssemblyName>Azure.Bicep.Core</AssemblyName> | |
<RootNamespace>Bicep.Core</RootNamespace> | |
<EnableNuget>true</EnableNuget> | |
<!-- Disable CS1591 Missing XML comment for publicly visible type or member for generated code --> | |
<NoWarn>$(NoWarn);CS1591</NoWarn> | |
<PackageTags>Azure;ResourceManager;ARM;Deployments;Templates;Bicep</PackageTags> | |
<Description> | |
Bicep compiler core functionality. | |
The Bicep team has made this NuGet package publicly available on nuget.org. While it is public, it is not a supported package. Any dependency you take on this package will be done at your own risk and we reserve the right to push breaking changes to this package at any time. | |
</Description> | |
<!-- enable trimmer warnings for Bicep CLI and projects it references --> | |
<EnableTrimAnalyzer>true</EnableTrimAnalyzer> | |
</PropertyGroup> |
<RootNamespace>
property does. I thought this should match the common prefix of the namespaces used by classes in this package, but I guess it is only used for embedded resources? We can change it in the future since this package doesn't have any resources.
Microsoft Reviewers: Open in CodeFlow