Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments from #771 review #807

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Conversation

anthony-c-martin
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 3, 2020

Codecov Report

Merging #807 into main will increase coverage by 0.05%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #807      +/-   ##
==========================================
+ Coverage   94.07%   94.12%   +0.05%     
==========================================
  Files         289      289              
  Lines       12116    12117       +1     
  Branches       12       12              
==========================================
+ Hits        11398    11405       +7     
+ Misses        718      712       -6     
Flag Coverage Δ
dotnet 94.84% <90.47%> (+0.05%) ⬆️
typescript 25.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core/Emit/ScopeHelper.cs 100.00% <ø> (ø)
src/Bicep.Core/Parser/ParseDiagnosticsVisitor.cs 92.00% <33.33%> (+0.33%) ⬆️
src/Bicep.Core/Emit/ExpressionConverter.cs 95.41% <100.00%> (+0.02%) ⬆️
src/Bicep.Core/Parser/Parser.cs 93.77% <100.00%> (+0.23%) ⬆️
src/Bicep.Core/Syntax/TargetScopeSyntax.cs 100.00% <100.00%> (ø)
src/Bicep.Core/TypeSystem/ModuleType.cs 100.00% <100.00%> (ø)
....LangServer/Completions/BicepCompletionProvider.cs 98.16% <0.00%> (-0.37%) ⬇️
...cep.LangServer.IntegrationTests/CompletionTests.cs 87.23% <0.00%> (+0.27%) ⬆️
src/Bicep.Core/TypeSystem/DeclaredTypeManager.cs 87.93% <0.00%> (+5.47%) ⬆️

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit eb3d221 into main Nov 4, 2020
@anthony-c-martin anthony-c-martin deleted the antmarti/module_fixes branch November 4, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants