This repository has been archived by the owner on Jan 21, 2025. It is now read-only.
test for @clientName of TCGC and @encodedName of compiler
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 55fe246 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
msyyc
requested review from
iscai-msft,
lmazuel,
m-nash,
joheredi,
srnagar,
weidongxu-microsoft,
tadelesh and
timotheeguerin
as code owners
msyyc
changed the title
@clientName of TCGC and @encodedName of compiler@clientName of TCGC and @encodedName of compiler
There was a problem hiding this comment.
Is it a direct copy from https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/projection/projected-name with only decorator change?
Yeah, almost |
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
qiaozha
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM, we should remove projectedName test cases after it's offically announced deprecated microsoft/typespec#2832
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
tadelesh
reviewed
Feb 20, 2024
tadelesh
reviewed
Feb 20, 2024
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Feb 20, 2024
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
chunyu3
reviewed
Feb 20, 2024
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
packages/cadl-ranch-specs/http/projection/client-encoded-name/main.tsp
Outdated
Show resolved
Hide resolved
qiaozha
reviewed
Feb 21, 2024
qiaozha
requested review from
timotheeguerin,
tadelesh,
chunyu3 and
weidongxu-microsoft
chunyu3
reviewed
Feb 21, 2024
|
others LGTM |
tadelesh
approved these changes
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #508, #509
@projectedNameso devs shall be able to add the test with few cost