Fix the bug that speaker option flickering when camera on/off #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PorterNan
requested review from
JamesBurnside,
alkwa-msft,
dmceachernmsft,
carocao-msft,
edwardlee-msft,
mgamis-msft,
prabhjot-msft,
jimchou-dev,
vhuseinova-msft,
Leah-Xia-Microsoft,
jpeng-ms,
waynemo,
emlynmac,
JoshuaLai and
palatter
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-cfykkanopr.chromatic.com/ |
Calling bundle size is not changed.
|
Chat bundle size is not changed.
|
CallWithChat bundle size is not changed.
|
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-xwpgzmhwnt.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-jyyeziutwx.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-npfmtesfau.chromatic.com/ |
dmceachernmsft
approved these changes
Sep 4, 2024
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-xrbqvmchlc.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-ztlvddaylo.chromatic.com/ |
edwardlee-msft
approved these changes
Sep 6, 2024
|
nice good catch! I wonder where we do something similar. We probably have done this quite often |
|
Storybook 6 URL https://60c7ae6891f0e90039d7cd54-cslqrgbxef.chromatic.com/ |
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-kjdpsktmih.chromatic.com/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix for bug: https://skype.visualstudio.com/SPOOL/_workitems/edit/3830093
The reason is the same as the one fixed by @edwardlee-msft, a new react component will create a new dom subtree which will attach a new dom element each time of re-render - either use "useMemo" or use none React component style to avoid this one.
#4936
Before:
After:
Why
How Tested
Process & policy checklist
Is this a breaking change?