Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated api #5553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

updated api #5553

wants to merge 1 commit into from

Conversation

cn0151
Copy link
Member

@cn0151 cn0151 commented Jan 13, 2025

What

Updated the API to include a new conditional compile

Why

Needed to ensure together mode is not included in the stable API

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@cn0151 cn0151 added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Jan 13, 2025
@cn0151 cn0151 marked this pull request as ready for review January 14, 2025 01:06
@cn0151 cn0151 requested review from a team as code owners January 14, 2025 01:06
@cn0151 cn0151 closed this Jan 14, 2025
@carocao-msft carocao-msft reopened this Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1768952
  • Base size: 1768952
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 11767078
  • Base size: 11767078
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 11767065
  • Base size: 11767065
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mpleevkepd.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27842 / 44291
62.86%		 27842 / 44291
62.86%		 782 / 1422
54.99%		 2319 / 3688
62.87%
Current 27841 / 44291
62.85%		 27841 / 44291
62.85%		 782 / 1422
54.99%		 2319 / 3692
62.81%
Diff -1 / 0
-0.01%		 -1 / 0
-0.01%		 0 / 0
0%		 0 / 4
-0.06%

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 56693 / 93264
60.78%		 56693 / 93264
60.78%		 1156 / 2667
43.34%		 3403 / 5677
59.94%
Current 56699 / 93265
60.79%		 56699 / 93265
60.79%		 1156 / 2667
43.34%		 3446 / 5701
60.44%
Diff 6 / 1
0.01%		 6 / 1
0.01%		 0 / 0
0%		 43 / 24
0.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carocao-msft carocao-msft carocao-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees

@dmceachernmsft dmceachernmsft

@carocao-msft carocao-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cn0151 @carocao-msft @dmceachernmsft