Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storybook concept pages to match their corresponding conceptual docs #5613

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

carocao-msft
Copy link
Contributor

What

Update storybook concept pages to match their corresponding conceptual docs

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Copy link
Contributor

github-actions bot commented Feb 4, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28048 / 44658
62.8%
28048 / 44658
62.8%
786 / 1436
54.73%
2345 / 3726
62.93%
Current 28043 / 44658
62.79%
28043 / 44658
62.79%
786 / 1436
54.73%
2334 / 3716
62.8%
Diff -5 / 0
-0.01%
-5 / 0
-0.01%
0 / 0
0%
-11 / -10
-0.13%

Copy link
Contributor

github-actions bot commented Feb 4, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 57068 / 94144
60.61%
57068 / 94144
60.61%
1161 / 2690
43.15%
3525 / 5766
61.13%
Current 57058 / 94144
60.6%
57058 / 94144
60.6%
1161 / 2690
43.15%
3449 / 5725
60.24%
Diff -10 / 0
-0.01%
-10 / 0
-0.01%
0 / 0
0%
-76 / -41
-0.89%


ACS users must have the Organizer, Co-organizer, or Presenter role to use the media access feature.
During a large virtual visit with multiple doctors, the host can use hard mute to ensure that only the speaker is heard, reducing interruptions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I heard from PM that hard mute is internal word. From the UI menu we have "Disable mic".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

ACS users must have the Organizer, Co-organizer, or Presenter role to use the media access feature.
During a large virtual visit with multiple doctors, the host can use hard mute to ensure that only the speaker is heard, reducing interruptions.

In a virtual banking session, the host can video mute participants to maintain focus on the presentation, ensuring no distractions from video feeds.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

video mute? From UI menu we have "Disable camera".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

github-actions bot commented Feb 4, 2025


## Azure Communication Service Based Captions
## ACS Based Captions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Azure Communication Service still. we try to avoid using the acronym in the documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Feb 6, 2025

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Chat bundle size is not changed.

  • Current size: 1777205
  • Base size: 1777205
  • Diff size: 0

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants