Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix][a11y] Resolve first focus order on initial load and remove autofocus constraints on CommonControlBar #5631

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

edwardlee-msft
Copy link
Contributor

What

Focus on remote tile more options first one page load.
Reorder the positioning of floating local video tile layerhost so that it is not the first focusable element on load
Remove autofocus on controlbar on first load.

Screen.Recording.2025-02-07.at.14.25.46.mov

Showing that mobile was not impacted:
Screenshot 2025-02-07 at 14 27 56

Why

A11y requirements require that focus land on first actionable item.
Need to remove autofocus on hidden element in controlbar as it takes initial focus away from the MediaGallery

More details regarding ControlBarCommon changes
James did some work to make focus reland on the control bar after captions is closed using the captions banner more options Turn off Captions button. Refer to this pr #5438

However, after my testing, this is not needed. With or without his code, if you tab after closing captions using the more options from the captions banners you will still land on the Microphone button.

HiddenFocus was removed as there is a new requirement with the more options button on remotevideotiles requiring first tabbable focus.

Additionally, because we have the new "Waiting for others" to join page, we do not have a focusable local video tile, etc on first render. Yay! So in this case, the focus will land correctly on the controlbar as the first actionable item.

How Tested

MacOS. CallWithChat sample locally.

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 7, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 10, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 10, 2025
@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 10, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 10, 2025
@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 10, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 10, 2025
Copy link
Contributor

Copy link
Contributor

Copy link
Contributor

github-actions bot commented Feb 10, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58286 / 94213
61.86%
58286 / 94213
61.86%
1177 / 2694
43.68%
3493 / 5801
60.21%
Current 58214 / 94166
61.82%
58214 / 94166
61.82%
1177 / 2693
43.7%
3558 / 5836
60.96%
Diff -72 / -47
-0.04%
-72 / -47
-0.04%
0 / -1
0.02%
65 / 35
0.75%

Copy link
Contributor

github-actions bot commented Feb 10, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27979 / 44645
62.66%
27979 / 44645
62.66%
786 / 1436
54.73%
2340 / 3713
63.02%
Current 27986 / 44645
62.68%
27986 / 44645
62.68%
786 / 1436
54.73%
2357 / 3725
63.27%
Diff 7 / 0
0.02%
7 / 0
0.02%
0 / 0
0%
17 / 12
0.25%

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 11, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 11, 2025
@edwardlee-msft edwardlee-msft added the update_snapshots Set this label to request automated update of UI snapshots label Feb 11, 2025
@github-actions github-actions bot removed the update_snapshots Set this label to request automated update of UI snapshots label Feb 11, 2025
Copy link
Contributor

Chat bundle size is decreased✅.

  • Current size: 1777255
  • Base size: 1777256
  • Diff size: -1

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants