-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix][a11y] Resolve first focus order on initial load and remove autofocus constraints on CommonControlBar #5631
base: main
Are you sure you want to change the base?
[bugfix][a11y] Resolve first focus order on initial load and remove autofocus constraints on CommonControlBar #5631
Conversation
Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fvvfzufkdu.chromatic.com/ |
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
https://github.com/Azure/communication-ui-library into elee/bugfix-a11y-incorrect-focus-order-in-call-screen
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-fxirpcbyfs.chromatic.com/ |
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jmshascwbr.chromatic.com/ |
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-lcosyykqys.chromatic.com/ |
@azure/communication-react jest test coverage for beta.
|
@azure/communication-react jest test coverage for stable.
|
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
1 similar comment
Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot. |
Chat bundle size is decreased✅.
|
CallWithChat bundle size is not changed.
|
Calling bundle size is not changed.
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-riyhbtbkbo.chromatic.com/ |
What
Focus on remote tile more options first one page load.
Reorder the positioning of floating local video tile layerhost so that it is not the first focusable element on load
Remove autofocus on controlbar on first load.
Screen.Recording.2025-02-07.at.14.25.46.mov
Showing that mobile was not impacted:
![Screenshot 2025-02-07 at 14 27 56](https://private-user-images.githubusercontent.com/97130533/411103609-276f845b-5e02-4058-bf14-ae7880da72cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMjc4NjIsIm5iZiI6MTczOTMyNzU2MiwicGF0aCI6Ii85NzEzMDUzMy80MTExMDM2MDktMjc2Zjg0NWItNWUwMi00MDU4LWJmMTQtYWU3ODgwZGE3MmNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDAyMzI0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQyZTUzN2VkZGEyNzY2OWIwNWYzZjQzYmYyNmIxNmIwN2FhOTc4OGRhY2FhMmRlNjczNzhkMDdlZjA4YzRiMzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.el6yE_8MfHQmRjrOEvBhad1TiuEWUbe4bvcW0465AA4)
Why
A11y requirements require that focus land on first actionable item.
Need to remove autofocus on hidden element in controlbar as it takes initial focus away from the MediaGallery
More details regarding ControlBarCommon changes
James did some work to make focus reland on the control bar after captions is closed using the captions banner more options Turn off Captions button. Refer to this pr #5438
However, after my testing, this is not needed. With or without his code, if you tab after closing captions using the more options from the captions banners you will still land on the Microphone button.
HiddenFocus was removed as there is a new requirement with the more options button on remotevideotiles requiring first tabbable focus.
Additionally, because we have the new "Waiting for others" to join page, we do not have a focusable local video tile, etc on first render. Yay! So in this case, the focus will land correctly on the controlbar as the first actionable item.
How Tested
MacOS. CallWithChat sample locally.
Process & policy checklist
Is this a breaking change?