Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDBuild latest localization #5636

Merged
merged 4 commits into from
Feb 10, 2025
Merged

TDBuild latest localization #5636

merged 4 commits into from
Feb 10, 2025

Conversation

dmceachernmsft
Copy link
Member

What

Update strings for 1.24.0

Why

updates the localization strings for the latest release

https://skype.visualstudio.com/SPOOL/_workitems/edit/4024658

How Tested

TD build

@dmceachernmsft dmceachernmsft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Feb 10, 2025
@dmceachernmsft dmceachernmsft requested review from a team as code owners February 10, 2025 22:03
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-cyhqglbuyy.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28044 / 44645
62.81%		 28044 / 44645
62.81%		 786 / 1436
54.73%		 2369 / 3735
63.42%
Current 27979 / 44645
62.66%		 27979 / 44645
62.66%		 786 / 1436
54.73%		 2349 / 3718
63.17%
Diff -65 / 0
-0.15%		 -65 / 0
-0.15%		 0 / 0
0%		 -20 / -17
-0.25%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58323 / 94213
61.9%		 58323 / 94213
61.9%		 1177 / 2694
43.68%		 3522 / 5823
60.48%
Current 58286 / 94213
61.86%		 58286 / 94213
61.86%		 1177 / 2694
43.68%		 3493 / 5801
60.21%
Diff -37 / 0
-0.04%		 -37 / 0
-0.04%		 0 / 0
0%		 -29 / -22
-0.27%

@dmceachernmsft dmceachernmsft enabled auto-merge (squash) February 10, 2025 22:31
@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1777256
  • Base size: 1777256
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pkmjflvtjw.chromatic.com/

@dmceachernmsft dmceachernmsft merged commit e19436b into main Feb 10, 2025
41 checks passed
@dmceachernmsft dmceachernmsft deleted the td/update-strings-20250210-220026 branch February 10, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@carocao-msft carocao-msft carocao-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

Assignees

@mgamis-msft mgamis-msft

@carocao-msft carocao-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmceachernmsft @mgamis-msft @carocao-msft @edwardlee-msft