Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for capitalization collations #2350

Closed
RubenCerna2079 opened this issue Aug 23, 2024 · 1 comment · Fixed by #2387
Closed

Add test for capitalization collations #2350

RubenCerna2079 opened this issue Aug 23, 2024 · 1 comment · Fixed by #2387
Assignees
@RubenCerna2079
Labels
testing Test related issue.
Milestone
1.3

Comments

@RubenCerna2079
Copy link
Contributor

RubenCerna2079 commented Aug 23, 2024 •
edited
Loading

Need to add new tests related to collations based on capitalization. Related to main issue #1535.

Some examples of this would be to ensure it works with both cases SELECT json_agg(to_jsonb(table0)) FROM (SELECT title FROM books ORDER BY title asc) as table0 and SELECT json_agg(to_jsonb(table0)) FROM (SELECT TITLE FROM BOOKS ORDER BY TITLE asc) as table0.
@RubenCerna2079 RubenCerna2079 added the testing Test related issue. label Aug 23, 2024
@RubenCerna2079 RubenCerna2079 self-assigned this Aug 23, 2024
@seantleonard
Copy link
Contributor

might be helpful have an example of what you want to test

@RubenCerna2079 RubenCerna2079 mentioned this issue Sep 18, 2024
Merged
2 tasks
@RubenCerna2079 RubenCerna2079 linked a pull request Sep 18, 2024 that will close this issue
Capitalization Collation Tests #2387
Merged
2 tasks
@RubenCerna2079 RubenCerna2079 added this to the 1.3 milestone Sep 25, 2024
RubenCerna2079 added a commit that referenced this issue Oct 11, 2024
@RubenCerna2079
Capitalization Collation Tests (#2387)
d9fd18c 
## Why make this change?

Solves issue #2350, to add collation tests related to capitalization.

## What is this change?

Added collation tests related to case sensitivity for `MSSQL`, `MYSQL`,
& `POSTGRESQL` by creating a new `GraphQLCollationTests` file under
`SQLTests` that will have all the tests related to changes in collations
for SQL databases.

## How was this tested?

- [X] Integration Tests
- [ ] Unit Tests

---------

Co-authored-by: Ruben Cerna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RubenCerna2079 RubenCerna2079

Labels
testing Test related issue.
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Capitalization Collation Tests Azure/data-api-builder
2 participants
@seantleonard @RubenCerna2079