-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved stored procedure parameter value type handling during GraphQL schema creation #1383
Merged
seantleonard
merged 16 commits into
main
from
dev/seleonar/DecimalToLongGraphQL_Issue1221
Apr 4, 2023
Merged
Improved stored procedure parameter value type handling during GraphQL schema creation #1383
seantleonard
merged 16 commits into
main
from
dev/seleonar/DecimalToLongGraphQL_Issue1221
Apr 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne type from database metadata instead of inferring incorrect and/or imprecise type.
…chema object for both mutation and query stored procedures. The SP param value types are properly hydrated from db metadata.
seantleonard
requested review from
mbhaskar,
Aniruddh25,
JelteF,
Mathos1432,
gledis69,
aaronburtle,
milismsft,
junsu0ms,
tarazou9,
ayush3797,
abhishekkumams,
aaronpowell,
severussundar and
ravishetye
as code owners
March 30, 2023 00:32
Aniruddh25
reviewed
Mar 30, 2023
Aniruddh25
reviewed
Mar 30, 2023
Aniruddh25
reviewed
Mar 30, 2023
Aniruddh25
reviewed
Mar 30, 2023
Aniruddh25
reviewed
Mar 30, 2023
Aniruddh25
reviewed
Mar 30, 2023
Aniruddh25
reviewed
Mar 31, 2023
Aniruddh25
reviewed
Mar 31, 2023
Aniruddh25
reviewed
Mar 31, 2023
Aniruddh25
reviewed
Mar 31, 2023
src/Service.Tests/GraphQLBuilder/Sql/StoredProcedureBuilderTests.cs
Outdated
Show resolved
Hide resolved
Aniruddh25
reviewed
Mar 31, 2023
src/Service.Tests/GraphQLBuilder/Sql/StoredProcedureBuilderTests.cs
Outdated
Show resolved
Hide resolved
Aniruddh25
reviewed
Mar 31, 2023
src/Service.Tests/GraphQLBuilder/Sql/StoredProcedureBuilderTests.cs
Outdated
Show resolved
Hide resolved
ayush3797
reviewed
Mar 31, 2023
… updated exception messaging and capturing
…e different DateTime vs DateTimeOffset types.
…e different DateTime vs DateTimeOffset types.
aaronburtle
reviewed
Apr 3, 2023
aaronburtle
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for getting this in for March!
Aniruddh25
reviewed
Apr 3, 2023
Aniruddh25
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for uncovering some new data type issues and adding better tests!
…/github.com/Azure/data-api-builder into dev/seleonar/DecimalToLongGraphQL_Issue1221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?
Sample Request(s)