Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design doc and diagram for Hot Reload feature #1811

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

aaronburtle
Copy link
Contributor

Why make this change?

This is related to the following Hot Reload PR #1726

and this issue #67

It adds a design doc to get feedback and iterate on how to implement the Hot Reloading feature. Hot Reloading will be on going work as all of the needed features to support it entirely are added.

What is this change?

Adds the design doc and a basic diagram for the Hot Reload feature.

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some thoughts

docs/design/HotReloadDoc.md Outdated Show resolved Hide resolved
docs/design/HotReloadDoc.md Outdated Show resolved Hide resolved
docs/design/HotReloadDoc.md Outdated Show resolved Hide resolved
docs/design/HotReloadDoc.md Show resolved Hide resolved
docs/design/HotReloadDoc.md Show resolved Hide resolved
docs/design/HotReloadDoc.md Outdated Show resolved Hide resolved
docs/design/HotReloadDoc.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed design and diagram! Left a few nits.

docs/design/HotReloadDoc.md Outdated Show resolved Hide resolved
docs/design/HotReloadDoc.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for keeping the design up to date!

@Aniruddh25
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@rohkhann rohkhann self-requested a review November 15, 2023 01:10
@aaronburtle aaronburtle enabled auto-merge (squash) November 15, 2023 07:04
@aaronburtle
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@aaronburtle aaronburtle merged commit ac2f79e into main Nov 15, 2023
@aaronburtle aaronburtle deleted the dev/aaronburtle/HotReloadDesignDoc branch November 15, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants