Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add design doc for dab configure #2338

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Add design doc for dab configure #2338

merged 9 commits into from
Sep 9, 2024

Conversation

abhishekkumams
Copy link
Contributor

Why make this change?

What is this change?

  • Adding a new design doc to help contributors to get an understanding of how to add new options in dab configure command.

@abhishekkumams abhishekkumams self-assigned this Aug 16, 2024
@abhishekkumams abhishekkumams added documentation Improvements or additions to documentation cli labels Aug 16, 2024
@abhishekkumams
Copy link
Contributor Author

/azp run

seantleonard
seantleonard reviewed Aug 22, 2024
View reviewed changes
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
@seantleonard
Copy link
Contributor

@RubenCerna2079 your feedback would be helpful here to determine how you can add cli functionality to modify the property you add in #1645

@abhishekkumams
Copy link
Contributor Author

/azp run

seantleonard
seantleonard reviewed Aug 28, 2024
View reviewed changes
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
docs/design/dab-configure.md Outdated Show resolved Hide resolved
@seantleonard
Copy link
Contributor

The feedback above was in the original round of feedback and seems to have been missed. Added again as fresh feedback threads.

@abhishekkumams
Copy link
Contributor Author

/azp run

@seantleonard seantleonard enabled auto-merge (squash) September 9, 2024 19:39
@seantleonard
Copy link
Contributor

/azp run

@seantleonard seantleonard added this to the 1.3 milestone Sep 9, 2024
@seantleonard
Copy link
Contributor

/azp run

@seantleonard seantleonard merged commit bbe1b5f into main Sep 9, 2024
7 checks passed
@seantleonard seantleonard deleted the dev/abhishekkuma/add_design_doc_dab_configure branch September 9, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenCerna2079 RubenCerna2079 RubenCerna2079 approved these changes

@seantleonard seantleonard seantleonard approved these changes

@Aniruddh25 Aniruddh25 Awaiting requested review from Aniruddh25 Aniruddh25 is a code owner

@aaronburtle aaronburtle Awaiting requested review from aaronburtle aaronburtle is a code owner

@ravishetye ravishetye Awaiting requested review from ravishetye ravishetye is a code owner

@rohkhann rohkhann Awaiting requested review from rohkhann rohkhann is a code owner

@neeraj-sharma2592 neeraj-sharma2592 Awaiting requested review from neeraj-sharma2592 neeraj-sharma2592 is a code owner

@sourabh1007 sourabh1007 Awaiting requested review from sourabh1007 sourabh1007 is a code owner

Assignees

@abhishekkumams abhishekkumams

Labels
cli documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

[Design Guide] Add new dab configure options
3 participants
@abhishekkumams @seantleonard @RubenCerna2079