Add log-level property to config schema #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenCerna2079
requested review from
Aniruddh25,
seantleonard,
aaronburtle,
abhishekkumams,
ravishetye,
rohkhann,
neeraj-sharma2592 and
sourabh1007
as code owners
|
/azp run |
aaronburtle
reviewed
Sep 5, 2024
seantleonard
reviewed
Sep 5, 2024
…level_property_runtime_config' into dev/rubencerna/log-level_property_runtime_config Fixes comments
|
/azp run |
|
/azp run |
|
/azp run |
seantleonard
reviewed
Sep 6, 2024
aaronburtle
reviewed
Sep 6, 2024
aaronburtle
approved these changes
Sep 6, 2024
…level_property_runtime_config' into dev/rubencerna/log-level_property_runtime_config
|
/azp run |
|
/azp run |
src/Service.Tests/Unittests/RuntimeConfigLoaderJsonDeserializerTests.cs
Outdated
Show resolved
Hide resolved
src/Service.Tests/Unittests/RuntimeConfigLoaderJsonDeserializerTests.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
added 2 commits
September 11, 2024 14:29
…level_property_runtime_config' into dev/rubencerna/log-level_property_runtime_config
|
/azp run |
|
/azp run |
seantleonard
approved these changes
Sep 12, 2024
|
/azp run |
2 similar comments
|
/azp run |
|
/azp run |
RubenCerna2079
deleted the
dev/rubencerna/log-level_property_runtime_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Adds log-level property to dab config file under the runtime section, closing issue #1645. The log-level is necessary to receive updates from the program, and with this property, it gives the users the ability to change what type of information they receive from the program. Lastly, it allows the users to have more options on how to change the log-level property, be it through the config file or the CLI.
What is this change?
First, the log-level property was added to the config file schema, in order for the user to have the ability to add the property into their config file. In order to save the information that is inside the property, a new object model named
LogLevelOptionswas created, inside of it is a new object model namedLevelwith the purpose of showing all of the possible values in an enum type. ALogLevelOptionswas then added toRuntimeOptionsso the program knows in which section it is supposed to parse the information. A new converterLogLevelOptionsConverterFactorywas created in order to allow the property in the config file to be deserialized. The logic inStartupfile was modified to first tries to set the loggers based on the log-level property, in the case that log-level is null, it will fall back on the logic that was set up forHost Mode. New tests were created inConfigurationTeststo test the validity of the code.How was this tested?