Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new OpenApi Document in the case of a Hot Reload #2384

Merged
merged 24 commits into from
Sep 28, 2024

Conversation

aaronburtle
Copy link
Contributor

Why make this change?

Closes #1869

What is this change?

Create a function in OpenApiDocumentor that invokes a new call to the CreateDocument() function to refresh the OpenApiDocument. Add an event handler, and subscribe the function for calling CreateDocument() to that handler when constructing the OpenApiDocumentor

How was this tested?

Current test suite, manually ran.

Sample Request(s)

N/A

@aaronburtle aaronburtle added the 🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal label Sep 14, 2024
@aaronburtle aaronburtle added this to the 1.3 milestone Sep 14, 2024
@aaronburtle aaronburtle self-assigned this Sep 14, 2024
@aaronburtle
Copy link
Contributor Author

/azp run

Copy link
Contributor

@seantleonard seantleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and feedback for touching this up

src/Config/CustomEventArgs.cs Outdated Show resolved Hide resolved
src/Config/HotReloadEventHandler.cs Outdated Show resolved Hide resolved
src/Config/HotReloadEventHandler.cs Outdated Show resolved Hide resolved
src/Config/RuntimeConfigLoader.cs Outdated Show resolved Hide resolved
src/Config/RuntimeConfigLoader.cs Outdated Show resolved Hide resolved
src/Config/RuntimeConfigLoader.cs Outdated Show resolved Hide resolved
src/Config/CustomEventArgs.cs Outdated Show resolved Hide resolved
src/Config/RuntimeConfigLoader.cs Outdated Show resolved Hide resolved
src/Config/HotReloadEventHandler.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@Aniruddh25 Aniruddh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as long as all the open comments are addressed.

@aaronburtle
Copy link
Contributor Author

/azp run

@aaronburtle
Copy link
Contributor Author

/azp run

@aaronburtle
Copy link
Contributor Author

/azp run

@aaronburtle
Copy link
Contributor Author

/azp run

@aaronburtle
Copy link
Contributor Author

/azp run

@aaronburtle aaronburtle merged commit 7418653 into main Sep 28, 2024
7 checks passed
@aaronburtle aaronburtle deleted the dev/aaronburtle/EventHandleOpenApiDoc branch September 28, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥Hot Reload Tasks related to DAB's Hot Reload feature proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot Reload of the OpenApi Document
4 participants