-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new OpenApi Document in the case of a Hot Reload #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
added
the
🔥Hot Reload
Tasks related to DAB's Hot Reload feature proposal
label
Sep 14, 2024
aaronburtle
requested review from
Aniruddh25,
seantleonard,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592 and
sourabh1007
as code owners
September 14, 2024 01:21
/azp run |
seantleonard
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions and feedback for touching this up
Aniruddh25
reviewed
Sep 26, 2024
Aniruddh25
approved these changes
Sep 26, 2024
Aniruddh25
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as long as all the open comments are addressed.
seantleonard
approved these changes
Sep 27, 2024
Co-authored-by: Sean Leonard <[email protected]>
…ure/data-api-builder into dev/aaronburtle/EventHandleOpenApiDoc
/azp run |
/azp run |
/azp run |
/azp run |
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #1869
What is this change?
Create a function in
OpenApiDocumentor
that invokes a new call to theCreateDocument()
function to refresh theOpenApiDocument
. Add an event handler, and subscribe the function for callingCreateDocument()
to that handler when constructing theOpenApiDocumentor
How was this tested?
Current test suite, manually ran.
Sample Request(s)
N/A