Fix DataSourceName update for HotReload #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the correct way of updating the dataSourceName was already there in the initial PR here: https://github.com/Azure/data-api-builder/blob/741865371911ef0b8dc6a27d9bc9ef82470cfc16/src/Config/ObjectModel/RuntimeConfig.cs#L303 then in another refactor PR, it was incorrectly updated, ref: https://github.com/Azure/data-api-builder/pull/2356/files#r1781334859 This PR fixes this. Tests will be a part of another Hot Reload PR.
abhishekkumams
requested review from
Aniruddh25,
seantleonard,
aaronburtle,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592 and
sourabh1007
as code owners
|
/azp run |
1 similar comment
|
/azp run |
aaronburtle
approved these changes
Oct 2, 2024
|
/azp run |
|
In the tests section you wrote that "more tests should be part of other HotReload PRs". Do you mean tests related to the function |
correct integrations tests would be verifying this update logic as well. |
|
/azp run |
|
It would be helpful to have in PR description "Why" this change is correct and why the previous one is wrong |
seantleonard
approved these changes
Oct 9, 2024
|
/azp run |
|
/azp run |
|
/azp run |
1 similar comment
|
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
the correct way of updating the dataSourceName was already there in the initial PR here:
data-api-builder/src/Config/ObjectModel/RuntimeConfig.cs
Line 303 in 7418653
then in another refactor PR, it was incorrectly updated, ref: https://github.com/Azure/data-api-builder/pull/2356/files#r1781334859
The current code directly assigns a new value to
DefaultDataSourceName. However, this approach does not account for updating the different mappings related to DataSourceName when the application undergoes a hot reload. During a hot reload, it is crucial to maintain the same default data source name as before the hot reload to all the mappings for being consistent. This is because references to the data source depend on this name for lookups.The new method
UpdateDefaultDataSourceNameensures that the default data source name is updated correctly, maintaining consistency across hot reloads.What is this change?
How was this tested?