[Enhancement] dab configure --runtime GraphQL in CLI #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezal98
added
config
added 3 commits
October 14, 2024 13:36
… dev/sezalchug/addDabConfigureRuntime
|
@microsoft-github-policy-service agree company="Microsoft" |
|
/azp run |
|
/azp run |
sezal98
requested review from
Aniruddh25,
seantleonard,
aaronburtle,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592 and
sourabh1007
as code owners
|
add the screenshot in the sample request section. |
|
Also, add few lines for What is the Change? |
added 2 commits
October 15, 2024 19:17
seantleonard
approved these changes
Oct 17, 2024
Aniruddh25
reviewed
Oct 17, 2024
Aniruddh25
reviewed
Oct 17, 2024
Aniruddh25
reviewed
Oct 18, 2024
Aniruddh25
reviewed
Oct 18, 2024
Aniruddh25
reviewed
Oct 18, 2024
Aniruddh25
requested changes
Oct 18, 2024
added 2 commits
October 18, 2024 19:19
….com/Azure/data-api-builder into dev/sezalchug/addDabConfigureRuntime
Aniruddh25
reviewed
Oct 18, 2024
Aniruddh25
approved these changes
Oct 18, 2024
|
/azp run |
seantleonard
approved these changes
Oct 19, 2024
|
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
This change is related to allowing users to modify the config file with a simple CLI command.
This PR covers adding changes for field for GRAPHQL config parameters
Related to issue:
Parent Issue #2403
Sub Issue: #2422
What is the Change?
This change is to accomodate updation in runtime config from the CLI tool.
A change in adding RuntimeConfigValidatorUtil is added to make a static class which contains all the statis functions in RuntimeConfigValidator so that we dont have to create an object everytime we use this validator function. We can simply call this using the static function class.
[-] RuntimeConfigValidatorUtil also added another validation condition in the check where URI should not contain white-spaces along with reserved characters and starts with '/'.
How was this tested?
Sample Request(s)
dab configure --runtime.graphql.enabled true -c {ConfigFileName}dab configure --runtime.graphql.path /updatedPath -c {ConfigFileName}dab configure --runtime.graphql.allow-introspection true -c {ConfigFileName}dab configure --runtime.graphql.multiple-mutations.create.enabled true -c {ConfigFileName}