Add exponential backoff to reading config file #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronburtle
requested review from
Aniruddh25,
seantleonard,
abhishekkumams,
RubenCerna2079,
ravishetye,
rohkhann,
neeraj-sharma2592,
sourabh1007 and
sezal98
as code owners
|
LGTM |
RubenCerna2079
approved these changes
Nov 19, 2024
abhishekkumams
approved these changes
Nov 20, 2024
Co-authored-by: RubenCerna2079 <[email protected]>
|
/azp run |
|
/azp run |
|
/azp run |
|
/azp run |
abhishekkumams
pushed a commit
that referenced
this pull request
Nov 28, 2024
## Why make this change? Closes #2119 ## What is this change? We add a try catch around the file reading in the `FileSystemRuntimeConfigLoader` class, and implement an exponential backoff for reading said file. ## How was this tested? Manually tested and ran against the test suite. A manual test can be run by having an editor with the file in question open and then closing the editor during the reading process. ## Sample Request(s) N/A --------- Co-authored-by: RubenCerna2079 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
Closes #2119
What is this change?
We add a try catch around the file reading in the
FileSystemRuntimeConfigLoaderclass, and implement an exponential backoff for reading said file.How was this tested?
Manually tested and ran against the test suite. A manual test can be run by having an editor with the file in question open and then closing the editor during the reading process.
Sample Request(s)
N/A